Update to Yaps Subtitle Generator

Changed files

Choose a file to see its text changes. Binary or large files show metadata only.

.claude-plugin/plugin.json →

.codex-plugin/assets/composer-icon.png →

.codex-plugin/assets/logo-dark.png →

.codex-plugin/assets/logo.png →

.codex-plugin/plugin.json →

plugin.json →

scripts/yaps-cli-discovery.mjs →

scripts/yaps-plugin-runner.mjs →

skills/yaps-srt-generator/SKILL.md →

scripts/yaps-plugin-runner.mjs

− removed · + added

--- before
+++ after
@@ -106,10 +106,17 @@
   if (value.includes("enoent") || value.includes("local_yaps_unreachable")) return "local_yaps_unreachable";
   if (value.includes("keychain_unavailable")) return "credential_unavailable";
   if (value.includes("verification_unavailable") || value.includes("refresh_failed")) return "account_cache_incomplete";
-  for (const code of ["settings_path_mismatch", "credential_unavailable", "credential_missing", "account_cache_incomplete", "profile_lookup_failed", "platform_mismatch", "unauthenticated"]) {
+  for (const code of ["settings_path_mismatch", "desktop_account_unavailable", "credential_unavailable", "credential_missing", "account_cache_incomplete", "profile_lookup_failed", "platform_mismatch", "unauthenticated"]) {
     if (value.includes(code)) return code;
   }
-  if (value.includes("permission") || value.includes("denied")) return "permission_denied";
+  if (
+    value.includes("permission") ||
+    value.includes("denied") ||
+    value.includes("eperm") ||
+    value.includes("eacces") ||
+    value.includes("operation not permitted") ||
+    value.includes("not permitted")
+  ) return "permission_denied";
   if (value.includes("model") && (value.includes("unavailable") || value.includes("not found"))) return "model_unavailable";
   if (value.includes("network") || value.includes("offline") || value.includes("econn")) return "network_unavailable";
   if (value.includes("timeout") || value.includes("timed out")) return "timeout";
@@ -119,6 +126,16 @@
   return "unknown";
 }
 
+// Yaps CLI exit codes (documented in `yaps --help`): 2 usage, 3 not_found,
+// 130 cancelled. Text classification wins when it is more specific.
+function classifyExit(code, output, launchError, yapsCli) {
+  const fromText = classifyError(output, launchError);
+  if (fromText !== "unknown" || !yapsCli) return fromText;
+  if (code === 2) return "invalid_input";
+  if (code === 3) return "not_found";
+  return "unknown";
+}
+
 function pruneInbox(inbox) {
   try {
     const entries = readdirSync(inbox)
@@ -177,10 +194,54 @@
 const context = ownerKey && identity ? { root, ownerKey, identity, host, action: parsed.action, stage: parsed.stage } : null;
 const operationId = randomUUID();
 const started = Date.now();
+let terminalWritten = false;
+let cancelled = false;
+let child = null;
+
+function finishOnce(status, errorCode = null) {
+  if (terminalWritten) return false;
+  terminalWritten = true;
+  writeEvent(context, status, operationId, errorCode, Date.now() - started);
+  return true;
+}
+
 writeEvent(context, "attempt", operationId);
 
+// Reasons and thrown values can contain customer content, paths, or command
+// output. Deliberately ignore them and persist only the reviewed `unknown`
+// diagnostic. `uncaughtExceptionMonitor` observes without changing Node's
+// normal fatal-exception behavior.
+process.once("uncaughtExceptionMonitor", () => {
+  finishOnce("failure", "unknown");
+});
+process.once("unhandledRejection", () => {
+  finishOnce("failure", "unknown");
+  process.exitCode = 1;
+});
+
+// Node runs `exit` listeners synchronously. This is the last cooperative
+// boundary for a runner that reaches process teardown without a child `close`
+// callback. It cannot run for SIGKILL, Windows TerminateProcess, power loss, or
+// an OS crash.
+process.once("exit", () => {
+  finishOnce(cancelled ? "cancelled" : "failure", cancelled ? "cancelled" : "unknown");
+});
+
+for (const signal of ["SIGINT", "SIGTERM"]) {
+  process.once(signal, () => {
+    cancelled = true;
+    finishOnce("cancelled", "cancelled");
+    if (child) {
+      try { child.kill(signal); } catch {}
+    } else {
+      process.exit(signal === "SIGINT" ? 130 : 143);
+    }
+  });
+}
+
 let [command, ...commandArguments] = parsed.command;
-if (isYapsCliCommand(command)) {
+const runsYapsCli = isYapsCliCommand(command);
+if (runsYapsCli) {
   const commandIsPath = command !== basename(command);
   const accountPreflight = isAuthStatusCommand(commandArguments);
   const requiresActiveAccount = commandRequiresActiveAccount(commandArguments);
@@ -191,14 +252,14 @@
   });
   if (!session.path) {
     const failure = classifyCliResolutionFailure(session);
-    writeEvent(context, "failure", operationId, failure.code, Date.now() - started);
+    finishOnce("failure", failure.code);
     process.stderr.write(`${failure.message}\n`);
     process.exit(failure.exitCode);
   }
   if (accountPreflight) {
     const account = diagnoseAccount(session);
     if (session.authStatusSafety !== "safe" || !session.auth) {
-      writeEvent(context, "failure", operationId, account.code, Date.now() - started);
+      finishOnce("failure", account.code);
       process.stderr.write(`${account.message}\n`);
       process.exit(78);
     }
@@ -208,36 +269,35 @@
       diagnostic_code: session.auth.diagnosticCode,
       credential_status: "not_accessed",
     };
-    writeEvent(context, "success", operationId, null, Date.now() - started);
+    if (account.code === "ready") finishOnce("success");
+    else finishOnce("failure", account.code);
     process.stdout.write(`${JSON.stringify(sanitized, null, commandArguments.includes("--pretty") ? 2 : 0)}\n`);
     process.exit(0);
   }
   if (requiresActiveAccount) {
     const account = diagnoseAccount(session);
     if (account.code !== "ready") {
-      writeEvent(context, "failure", operationId, account.code, Date.now() - started);
+      finishOnce("failure", account.code);
       process.stderr.write(`${account.message}\n`);
       process.exit(77);
     }
   }
   command = session.path;
-  commandArguments = applyResolvedSettings(commandArguments, session.settingsPath);
+  commandArguments = applyResolvedSettings(commandArguments, session.settingsPath, {
+    followDesktopAccount: session.auth?.diagnosticCode === "followed_desktop_account",
+  });
 }
 
 let outputTail = Buffer.alloc(0);
 let launchError = null;
-let cancelled = false;
-const child = spawn(command, commandArguments, { env: process.env, stdio: ["inherit", "pipe", "pipe"], windowsHide: true });
+child = spawn(command, commandArguments, { env: process.env, stdio: ["inherit", "pipe", "pipe"], windowsHide: true });
 child.stdout.on("data", (chunk) => { outputTail = appendTail(outputTail, chunk); process.stdout.write(chunk); });
 child.stderr.on("data", (chunk) => { outputTail = appendTail(outputTail, chunk); process.stderr.write(chunk); });
 child.on("error", (error) => { launchError = error; });
-for (const signal of ["SIGINT", "SIGTERM"]) {
-  process.on(signal, () => { cancelled = true; try { child.kill(signal); } catch {} });
-}
 child.on("close", (code, signal) => {
-  const duration = Date.now() - started;
-  if (cancelled || signal) writeEvent(context, "cancelled", operationId, "cancelled", duration);
-  else if (code === 0) writeEvent(context, "success", operationId, null, duration);
-  else writeEvent(context, "failure", operationId, classifyError(outputTail.toString("utf8"), launchError), duration);
-  process.exitCode = code ?? (signal ? 1 : 127);
+  // A Yaps CLI stopped by Ctrl-C/SIGTERM (or `jobs cancel`) cleans up and exits 130.
+  if (cancelled || signal || code === 130) finishOnce("cancelled", "cancelled");
+  else if (code === 0) finishOnce("success");
+  else finishOnce("failure", classifyExit(code, outputTail.toString("utf8"), launchError, runsYapsCli));
+  process.exitCode ??= code ?? (signal ? 1 : 127);
 });